linqjs Issue Tracker Rss Feed

Edited Unassigned: Join issue [5161]

lxp270 — Tue, 07 May 2013 06:56:27 GMT

I what use Join in Linq.js, Is Different with C#?
``` C#
var table = from c in ctx.Users
join p in ctx.Structure
on c.StructureID equals p.StructureID.ToString()
where c.UserID < 276234
select c;
```
What can I do using linq.js achieve the above functions,it's two tables join by foreign key(ID)

Created Unassigned: Join issue [5161]

lxp270 — Tue, 07 May 2013 06:46:38 GMT

var table = from c in ctx.Users
join p in ctx.Structure
on c.StructureID equals p.StructureID.ToString()
where c.UserID < 276234
select c;
What can I do using linq.js achieve the above functions,it's two tables join by foreign key(ID)

Created Issue: Function-members of object is discarded from enumeration [5160]

andhaug — Sun, 10 Feb 2013 20:12:15 GMT

```
var obj1 = {
f: function () {
return "a";
}
};

Enumerable.From(obj1)
```

In the sample above with an object containing a function.
The function will be discarded from the enumeration on line 133 of linq.js (v.2.2.0.2). Excerpt below:

```
for (var key in obj)
{
if (!(obj[key] instanceof Function)) // <----- if clause that removes the function
{
array.push({ Key: key, Value: obj[key] });
}
}
```

Is this the intended behavior? If so, why, and is there any workaround for enumerating over function pointers in an object?

Created Issue: ToObject selectors with indexes [5159]

MgSam — Tue, 05 Feb 2013 17:33:26 GMT

Right now the Enumerable.ToObject() method (and possibly ToDictionary and ToLookup) do not provide an index argument for the key and value selectors. Providing this (as is done in Select), would be helpful.

Edited Issue: Use a better Dictionary class [5158]

MgSam — Tue, 05 Feb 2013 17:30:58 GMT

Right now the Dictionary class used in linq.js is fairly basic and not all that useful over a vanilla object. It also has the major drawback in that it can only use strings as keys. A more generic Dictionary that can use any object as keys would be a lot more useful.

Here is a good reference example: http://www.timdown.co.uk/jshashtable/

This example also includes a HashSet, which is another collection that would be really useful if integrated into linq.js (perhaps using an Enumerable.ToHashSet() method).

Created Issue: Use a better Dictionary class [5158]

MgSam — Tue, 05 Feb 2013 17:30:25 GMT

Commented Issue: Using linq.js with Knockout.js causes weird dictionary issue [5157]

neuecc — Tue, 22 Jan 2013 07:48:31 GMT

Given an object used as a plain key value dictionary, Enumerable.From will fail to consider any keys whose values are an observableArray. For example:

Enumerable.From({ 'example': ko.observableArray() }).ToArray()
=> []
Comments: Thanks for report. ko.observableArray is strange, ko.observableArray is function. Enumerable.from filter function value. Therefore result is empty. Please make an exclusive method. ``` Enumerable.fromObject = function (obj) { return Enumerable.Utils.createEnumerable(function () { var array = []; var index = 0; return Enumerable.Utils.createEnumerator( function () { for (var key in obj) { var value = obj[key]; if (Object.prototype.hasOwnProperty.call(obj, key)) { array.push({ key: key, value: value }); } } }, function () { return (index < array.length) ? this.yieldReturn(array[index++]) : this.yieldBreak(); }, function () { }); }) }; ``` usage ``` var xs = Enumerable.fromObject({ 'example': ko.observableArray() }).toArray(); ```

Commented Issue: Using linq.js with Knockout.js causes weird dictionary issue [5157]

neuecc — Tue, 22 Jan 2013 07:45:45 GMT

Given an object used as a plain key value dictionary, Enumerable.From will fail to consider any keys whose values are an observableArray. For example:

Enumerable.From({ 'example': ko.observableArray() }).ToArray()
=> []
Comments: Thanks for report. ko.observableArray is strange, ko.observableArray is function. Enumerable.from filter function value. Therefore result is empty. Please make an exclusive method. ``` Enumerable.fromObject = function (obj) { return Enumerable.Utils.createEnumerable(function () { var array = []; var index = 0; return Enumerable.Utils.createEnumerator( function () { for (var key in obj) { var value = obj[key]; if (Object.prototype.hasOwnProperty.call(obj, key)) { array.push({ key: key, value: value }); } } }, function () { return (index < array.length) ? this.yieldReturn(array[index++]) : false; }, function () { }); }) }; ``` usage example ``` var xs = Enumerable.fromObject({ 'example': ko.observableArray() }).toArray(); ```

Commented Issue: Using linq.js with Knockout.js causes weird dictionary issue [5157]

Igorbek — Sun, 20 Jan 2013 22:42:23 GMT

Commented Issue: Any should stop searching when first item matches condition [5156]

neuecc — Fri, 14 Dec 2012 17:51:28 GMT

Hi! I think that, in order to increase performance, you should stop the Any search when an element matches the condition. For example: var list=[{id:1},{id:2},{id:3}]; Enumarable.From(list).Any(function(x){ return x.id==1; }); This Any should not search in all items if the first item matches. Result will not vary if more than one element matches. Currently Any is searching in all the items of the enumerable. Anyway, awesome library, congratulations!
Comments: Thank you. But > Currently Any is searching in all the items of the enumerable. Is this right? Currently Any implementation(ver 2.2.0.2) is --- if (arguments.length == 0) return enumerator.MoveNext(); // case:function() while (enumerator.MoveNext()) // case:function(predicate) { if (predicate(enumerator.Current())) return true; } return false; --- search is stopped.

Created Issue: Using linq.js with Knockout.js causes weird dictionary issue [5157]

bytenik — Thu, 13 Dec 2012 13:39:41 GMT

Edited Issue: Any should stop searching when first item matches condition [5156]

wikimetal — Sun, 09 Dec 2012 22:38:27 GMT

Created Issue: Any should stop search when an item matches [5156]

wikimetal — Sun, 09 Dec 2012 22:37:40 GMT

Hi!

I think that, in order to increase performance, you should stop the Any search when an element matches the condition. For example:

var list=[{id:1},{id:2},{id:3}];
Enumarable.From(list).Any(function(x){
return x.id==1;
});

This Any should not search in all items if the first item matches. Result will not vary if more than one element matches.

Currently Any is searching in all the items of the enumerable.

Anyway, awesome library, congratulations!

Commented Issue: First() and FirstOrDefault() return different results [5144]

habeeb_matrix — Sat, 17 Nov 2012 10:01:18 GMT

Hi,
This is the first time I've used linq.js, so I could have the wrong end of the stick. From my C# experience I'd expect First() and FirstOrDefault() to return the same value, so long as the predicate finds a match. In my brief test, that doesn't appear to be the case.

Here's a quick node script to demonstrate:

require('./linq');

var x = [ 1 , 2, 3, 4, 5 ];

console.log(Enumerable.From(x).First('$>2')); // => 3, as expected
console.log(Enumerable.From(x).FirstOrDefault('$>2')); // => 1 ???

Have I misunderstood something about how linq.js works, or is this a bug?

Cheers,

Ben
Comments: Nice Post. this explains more about the use or first() and firstordefault(). http://dotnet-programming-solutions.blogspot.com/2012/10/when-to-use-first-and-firstordefault.html

Commented Issue: Sorting scandinavian alphabets [5139]

dvela1 — Thu, 08 Nov 2012 14:17:44 GMT

The default sort in javascript does not handle scandinavian alphabets correctly, sorting the special characters in the wrong order by default because of the letter order in unicode. This can be fixed using "localeCompare".
Comments: Why don't you just uppercase all the values and then do the compare. That should solve your compatibility problem.

Created Issue: Enumerable.Utils should have more basic function. [5155]

mogami — Sat, 27 Oct 2012 01:01:57 GMT

For plugin developers, it is better to expose internal functions, like following:
Enumerable.Utils.blank = Functions.Blank;
Enumerable.Utils.alwaysTrue = Functions.True;
Enumerable.Utils.identity = Functions.Identity;
Enumerable.Utils.dispose = Utils.dispose;

Because it reduces lines of plugin by eliminating re-definition.
1st, Functions.Blank are often used, because IEnumerator will do nothing at initializing and/or disposing in many cases, as you know.
2nd, Functions.Identity are also used to implement operators that accept function, like selectMany operator.
3rd, null-safe-dispose is useful to dispose enumerator that quit in the middle enumeration.

I think Functions.True is rarely used, but uniformity is better, maybe.

Commented Issue: Filter is not working on datetime field (Column) [5147]

neuecc — Mon, 20 Aug 2012 12:19:59 GMT

I have data having datetime field, and want to filter by date then it will return whole collection (didnt filter on specific datetime). Please check this issue because i am stuck in my project because i am using your library.

//Sample Data
var jsonResultTble = [{"ItemPostingId":3599,"Condition":"Very Good","Seller":"friendimran@hotmail.com","Rating":0,"School":"University of California-Los Angeles","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/30/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":false,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":1128,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null},{"ItemPostingId":3600,"Condition":"Very Good","Seller":"imran.raza@esoulconsultancy.com","Rating":18,"School":"Mississippi Valley State University","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/10/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":true,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":679,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null}];

//Apply Filter on AvailabilityDate field
var queryResult = $.Enumerable.From(jsonResultTble)
.Where("$.AvailabilityDate == '04/30/2012 12:00:00 AM'")
.Select("$.ItemPostingId").ToArray();

It should return one record but it didnt.
Comments: sorry, I can't understand which point is bad yet. Please write a concrete example of data.

Commented Issue: Filter is not working on datetime field (Column) [5147]

Neb37 — Fri, 17 Aug 2012 13:00:53 GMT

I have data having datetime field, and want to filter by date then it will return whole collection (didnt filter on specific datetime). Please check this issue because i am stuck in my project because i am using your library.

//Sample Data
var jsonResultTble = [{"ItemPostingId":3599,"Condition":"Very Good","Seller":"friendimran@hotmail.com","Rating":0,"School":"University of California-Los Angeles","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/30/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":false,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":1128,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null},{"ItemPostingId":3600,"Condition":"Very Good","Seller":"imran.raza@esoulconsultancy.com","Rating":18,"School":"Mississippi Valley State University","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/10/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":true,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":679,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null}];

//Apply Filter on AvailabilityDate field
var queryResult = $.Enumerable.From(jsonResultTble)
.Where("$.AvailabilityDate == '04/30/2012 12:00:00 AM'")
.Select("$.ItemPostingId").ToArray();

It should return one record but it didnt.
Comments: To be able to use OrderBy on date or datetime fields in string format, I used to tweak the compare methods by using date.js: Compare: function(a, b) { var DateA = Date.parse(a); var DateB = Date.parse(b); if (DateA == null || DateB == null) { return (a === b) ? 0 : (a > b) ? 1 : -1; } else { return (DateA.compareTo(DateB)) } },

Commented Issue: Filter is not working on datetime field (Column) [5147]

neuecc — Fri, 17 Aug 2012 08:10:37 GMT

I have data having datetime field, and want to filter by date then it will return whole collection (didnt filter on specific datetime). Please check this issue because i am stuck in my project because i am using your library.

//Sample Data
var jsonResultTble = [{"ItemPostingId":3599,"Condition":"Very Good","Seller":"friendimran@hotmail.com","Rating":0,"School":"University of California-Los Angeles","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/30/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":false,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":1128,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null},{"ItemPostingId":3600,"Condition":"Very Good","Seller":"imran.raza@esoulconsultancy.com","Rating":18,"School":"Mississippi Valley State University","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/10/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":true,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":679,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null}];

//Apply Filter on AvailabilityDate field
var queryResult = $.Enumerable.From(jsonResultTble)
.Where("$.AvailabilityDate == '04/30/2012 12:00:00 AM'")
.Select("$.ItemPostingId").ToArray();

It should return one record but it didnt.
Comments: At first AvailabilityDate's type is String. It isn't DateTime. So '04/30/2012' is not match. It is necessary to be '4/30/2012 12:00:00 AM'. // What is promblem of OrderBy? I checked following code and it works. Enumerable.From([new Date(2000, 10, 0), new Date(1999, 10, 0), new Date(2001, 10, 0)]) .OrderBy() .WriteLine();

Commented Issue: Filter is not working on datetime field (Column) [5147]

developerdavid — Thu, 16 Aug 2012 15:44:24 GMT

I have data having datetime field, and want to filter by date then it will return whole collection (didnt filter on specific datetime). Please check this issue because i am stuck in my project because i am using your library.

//Sample Data
var jsonResultTble = [{"ItemPostingId":3599,"Condition":"Very Good","Seller":"friendimran@hotmail.com","Rating":0,"School":"University of California-Los Angeles","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/30/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":false,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":1128,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null},{"ItemPostingId":3600,"Condition":"Very Good","Seller":"imran.raza@esoulconsultancy.com","Rating":18,"School":"Mississippi Valley State University","City":" ","State":" ","Comments":"N/A","RetailPrice":0,"TradeCredit":0,"AvailabilityDate":"4/10/2012 12:00:00 AM","SwapOptId":3,"IsAvailable":true,"BookConditionId":2,"ConditionValue":0.85,"SchoolId":679,"DeliveryId":1,"IsSell":false,"SellPrice":0,"PostedImages":null}];

//Apply Filter on AvailabilityDate field
var queryResult = $.Enumerable.From(jsonResultTble)
.Where("$.AvailabilityDate == '04/30/2012 12:00:00 AM'")
.Select("$.ItemPostingId").ToArray();

It should return one record but it didnt.
Comments: I am also having an issue with datetime fields, OrderBy doesn't seem to work on DateTime fields????